[webkit-reviews] review denied: [Bug 30578] WebInspector: Adds XHR Instrumentation to WebInspector Timeline : [Attachment 41513] WebInspector: adds XHR instrumentation to XMLHttpRequest for the TimelineAgent

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 20 15:51:17 PDT 2009


Pavel Feldman <pfeldman at chromium.org> has denied Eric Ayers
<zundel at google.com>'s request for review:
Bug 30578: WebInspector: Adds XHR Instrumentation to WebInspector Timeline
https://bugs.webkit.org/show_bug.cgi?id=30578

Attachment 41513: WebInspector: adds XHR instrumentation to XMLHttpRequest for
the TimelineAgent
https://bugs.webkit.org/attachment.cgi?id=41513&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Given that you require frontend to be present at all times timeline events are
fired, there is no need to create native structures for all of your event
types. Just dump them into the frontend using some static serializer methods.
You should be able to get rid of them all together actually (*TimelineItem).


More information about the webkit-reviews mailing list