[webkit-reviews] review denied: [Bug 19879] Inspector should support monitorEvents/un monitorEvents() in the command line : [Attachment 41089] proposed patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 19879: Inspector should support monitorEvents/un monitorEvents() in the
command line
https://bugs.webkit.org/show_bug.cgi?id=19879

Attachment 41089: proposed patch
https://bugs.webkit.org/attachment.cgi?id=41089&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
> +		   if (t[i] == \"mouse\") \

Use ===


> +		       te = te.concat([\"mousedown\", \"mouseup\", \"click\",
\"dblclick\", \

Use splice instead in order not to create new array instances.

> +		   if (t[i] == \"key\") \

Use ===


> +		   o.removeEventListener

Should you test for addEventListener / removeEvent listener on an object?
Does monitorEvent(null) provide meaningful feedback well?

Other than that r+.