[webkit-reviews] review denied: [Bug 30573] [Qt] Broken back/forward after using ErrorPageExtension to set error page : [Attachment 41508] patch 0.1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 20 12:17:02 PDT 2009


Adam Barth <abarth at webkit.org> has denied Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>'s request for review:
Bug 30573: [Qt] Broken back/forward after using ErrorPageExtension to set error
page
https://bugs.webkit.org/show_bug.cgi?id=30573

Attachment 41508: patch 0.1
https://bugs.webkit.org/attachment.cgi?id=41508&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I'd have to think more about whether this patch is correct, but I don't want to
accept any functional FrameLoader patches without tests.  We need more test
coverage of this code.


More information about the webkit-reviews mailing list