[webkit-reviews] review requested: [Bug 30574] [Qt] Qt browsers fail test LayoutTests/fast/history/clicked-link-is-visited.html : [Attachment 41510] fix patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 20 10:12:21 PDT 2009


Chang Shu <Chang.Shu at nokia.com> has asked  for review:
Bug 30574: [Qt] Qt browsers fail test
LayoutTests/fast/history/clicked-link-is-visited.html
https://bugs.webkit.org/show_bug.cgi?id=30574

Attachment 41510: fix patch
https://bugs.webkit.org/attachment.cgi?id=41510&action=review

------- Additional Comments from Chang Shu <Chang.Shu at nokia.com>
Two things probably can be discussed:
1. The expected text file is added to common folder. This may affect the test
result for GTK, win platform (Mac has its own expected results).
2. The default color #551A8B is expected. Is this consistent on all platforms?
Shall we set the visited color in the test case so as to make result
consistent?
Thanks!


More information about the webkit-reviews mailing list