[webkit-reviews] review denied: [Bug 20797] add Settings entries for per-script/lang generic family : [Attachment 38565] patch addressing Eric's concerns

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied  review:
Bug 20797: add Settings entries for per-script/lang generic family
https://bugs.webkit.org/show_bug.cgi?id=20797

Attachment 38565: patch addressing Eric's concerns
https://bugs.webkit.org/attachment.cgi?id=38565&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This broke the build:

Ld
/Volumes/Big/WebKit-BuildSlave/leopard-intel-debug/build/WebKitBuild/Debug/WebC
ore.framework/Versions/A/WebCore normal i386
    cd /Volumes/Big/WebKit-BuildSlave/leopard-intel-debug/build/WebCore
    /Developer/usr/bin/g++-4.2 -arch i386 -dynamiclib
-L/Volumes/Big/WebKit-BuildSlave/leopard-intel-debug/build/WebKitBuild/Debug
-F/Volumes/Big/WebKit-BuildSlave/leopard-intel-debug/build/WebKitBuild/Debug
-F/System/Library/Frameworks/Carbon.framework/Frameworks
-F/System/Library/Frameworks/ApplicationServices.framework/Frameworks -filelist
/Volumes/Big/WebKit-BuildSlave/leopard-intel-debug/build/WebKitBuild/WebCore.bu
ild/Debug/WebCore.build/Objects-normal/i386/WebCore.LinkFileList
-Wl,--no-demangle -exported_symbols_list
/Volumes/Big/WebKit-BuildSlave/leopard-intel-debug/build/WebKitBuild/Debug/Deri
vedSources/WebCore/WebCore.exp -install_name
/Volumes/Big/WebKit-BuildSlave/leopard-intel-debug/build/WebKitBuild/Debug/WebC
ore.framework/Versions/A/WebCore -mmacosx-version-min=10.5 -lWebCoreSQLite3
-lobjc -sub_library libobjc -umbrella WebKit -framework ApplicationServices
-framework Carbon -framework Cocoa -framework JavaScriptCore -licucore -lobjc
-lxml2 -framework OpenGL -framework QuartzCore -framework SystemConfiguration
-Wl,-single_module -compatibility_version 1 -current_version 532.3 -o
/Volumes/Big/WebKit-BuildSlave/leopard-intel-debug/build/WebKitBuild/Debug/WebC
ore.framework/Versions/A/WebCore
Undefined symbols:
  "__ZN7WebCore8Settings20setCursiveFontFamilyERKNS_12AtomicStringE",
referenced from:
     -exported_symbols_list command line option
  "__ZN7WebCore8Settings18setFixedFontFamilyERKNS_12AtomicStringE", referenced
from:
     -exported_symbols_list command line option
  "__ZN7WebCore8Settings22setSansSerifFontFamilyERKNS_12AtomicStringE",
referenced from:
     -exported_symbols_list command line option
  "__ZN7WebCore8Settings18setSerifFontFamilyERKNS_12AtomicStringE", referenced
from:
     -exported_symbols_list command line option
  "__ZN7WebCore8Settings20setFantasyFontFamilyERKNS_12AtomicStringE",
referenced from:
     -exported_symbols_list command line option
  "__ZN7WebCore8Settings21setStandardFontFamilyERKNS_12AtomicStringE",
referenced from:
     -exported_symbols_list command line option
ld: symbol(s) not found
collect2: ld returned 1 exit status
** BUILD FAILED **