[webkit-reviews] review requested: [Bug 30304] struct RGBA32Buffer is twice as big as the old ImageData of Qt : [Attachment 41472] Reduce RGBA32Buffer from 52bytes to 20 bytes per instance (take two)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 19 19:39:46 PDT 2009
Holger Freyther <zecke at selfish.org> has asked for review:
Bug 30304: struct RGBA32Buffer is twice as big as the old ImageData of Qt
https://bugs.webkit.org/show_bug.cgi?id=30304
Attachment 41472: Reduce RGBA32Buffer from 52bytes to 20 bytes per instance
(take two)
https://bugs.webkit.org/attachment.cgi?id=41472&action=review
------- Additional Comments from Holger Freyther <zecke at selfish.org>
Updated patch:
When RGBA32Buffer& frame was used IntRect& frame will be used
When RGBA32Buffer* frame was used IntRect* frame will be used.
m_rects[frameIndex] = newRect is specially not used as the frameIndex method
parameter is changed in the function body and will point to a different "frame"
when the assignment would be due.
More information about the webkit-reviews
mailing list