[webkit-reviews] review granted: [Bug 30083] Data loss occurs when unbolding nested bold tags. : [Attachment 41369] Fixes the loop in swapInNodePreservingAttributesAndChildren
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 19 14:32:56 PDT 2009
Eric Seidel <eric at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 30083: Data loss occurs when unbolding nested bold tags.
https://bugs.webkit.org/show_bug.cgi?id=30083
Attachment 41369: Fixes the loop in swapInNodePreservingAttributesAndChildren
https://bugs.webkit.org/attachment.cgi?id=41369&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
This would be much better as a test which showed PASS or FAIL. script-test
style tests could do that.
I might have written this a while loop instead. But the current for seems
fine. You might want a comment there:
62 nextChild = child->nextSibling(); // Save nextSibling() as
appendChild(child) will change child->nextSibling().
r+, but consider making this a script-test and adding a comment.
More information about the webkit-reviews
mailing list