[webkit-reviews] review granted: [Bug 30440] [GTK] Fails new test fast/js/navigator-language.html : [Attachment 41415] update test case to check against "en-us"
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 19 14:16:46 PDT 2009
Eric Seidel <eric at webkit.org> has granted Chang Shu <Chang.Shu at nokia.com>'s
request for review:
Bug 30440: [GTK] Fails new test fast/js/navigator-language.html
https://bugs.webkit.org/show_bug.cgi?id=30440
Attachment 41415: update test case to check against "en-us"
https://bugs.webkit.org/attachment.cgi?id=41415&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
I am confused by there being two unrelated patches on this bug.
This line is confusing:
11 Language tags should follow the specification below:
What you're quoting is a piece of a spec, so you either need to provide a link
to the original spec, or at least some description of where you got that
snippet. In this case it's from the RFC I mentioned.
Otherwise looks fine. Won't this cause failures on qt or gtk? OK to land w/
modifications. If you need the commit-queue to land this, please post a new
bug.
More information about the webkit-reviews
mailing list