[webkit-reviews] review denied: [Bug 30529] Hide Chromium's media slider thumb if no source has been loaded. : [Attachment 41440] Round 1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 19 14:02:15 PDT 2009
David Levin <levin at chromium.org> has denied Andrew Scherkus
<scherkus at chromium.org>'s request for review:
Bug 30529: Hide Chromium's media slider thumb if no source has been loaded.
https://bugs.webkit.org/show_bug.cgi?id=30529
Attachment 41440: Round 1
https://bugs.webkit.org/attachment.cgi?id=41440&action=review
------- Additional Comments from David Levin <levin at chromium.org>
r- to move out of the queue since Andrew said he is uploading something new.
> diff --git a/WebCore/rendering/RenderMediaControlsChromium.cpp
b/WebCore/rendering/RenderMediaControlsChromium.cpp
> + if (mediaElement->networkState() == HTMLMediaElement::NETWORK_EMPTY ||
> + mediaElement->networkState() == HTMLMediaElement::NETWORK_NO_SOURCE)
fyi, the || should be on the next line.
More information about the webkit-reviews
mailing list