[webkit-reviews] review denied: [Bug 30469] We should not bubble up events if we drag something to an iframe that has an invalid source : [Attachment 41343] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 19 13:49:51 PDT 2009


Eric Seidel <eric at webkit.org> has denied Jian Li <jianli at chromium.org>'s
request for review:
Bug 30469: We should not bubble up events if we drag something to an iframe
that has an invalid source
https://bugs.webkit.org/show_bug.cgi?id=30469

Attachment 41343: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=41343&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Do we have a test which covers the case of a valid source bubbling correctly?

This looks like copy-paste code which should be replaced by a static function,
no?


More information about the webkit-reviews mailing list