[webkit-reviews] review granted: [Bug 30473] Check COMPILER(MSVC) instead of PLATFORM(WIN_OS) to avoid the use of vasprintf. : [Attachment 41349] Use COMPILER(MSVC) guards to avoid vasprintf

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 30473: Check COMPILER(MSVC) instead of PLATFORM(WIN_OS) to avoid the use of
vasprintf.
https://bugs.webkit.org/show_bug.cgi?id=30473

Attachment 41349: Use COMPILER(MSVC) guards to avoid vasprintf
https://bugs.webkit.org/attachment.cgi?id=41349&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
+	 No new tests. (OOPS!)

the OOPS will cause the commit to fail.  The one in "reviewed by" is OK,
because the commit-queue will substitute in the right thing.  BUt the no new
tests line should be replaced by something explaingin why this does not need
testing or why testing is impossible.

Something simple like:

Build fix only, no tests possible.

would be fine.

cq- since the commit-queue can't handle this as-is.  If you post a new patch 
w/o the second OOPS! that can be r+/cq+'d though.