[webkit-reviews] review requested: [Bug 30530] Replace QWebFrame::clipContentsToViewport with better API : [Attachment 41444] First part of the clipContentsToViewport fix (introduce paint method, deprecate render)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 19 13:37:40 PDT 2009


Kenneth Rohde Christiansen <kenneth at webkit.org> has asked  for review:
Bug 30530: Replace QWebFrame::clipContentsToViewport with better API
https://bugs.webkit.org/show_bug.cgi?id=30530

Attachment 41444:  First part of the clipContentsToViewport fix (introduce
paint method, deprecate render) 
https://bugs.webkit.org/attachment.cgi?id=41444&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
We had a quick round of API review with Matthias here at the DevDays and came
up with the following suggestions for changes:

* QWebFrame::clipContentsToViewport:

    1) Remove the property
    2) Deprecate QWebFrame::render()
    3) Introduce QWebFrame::paint(QWebFrame::PaintOptions opts =
QWebFrame::AllElements), so that one can for eaxmple call

    frame->paint(QWebFrame::Contents);
    frame->paint(QWebFrame::Contents | QWebFrame::ScrollBars);


More information about the webkit-reviews mailing list