[webkit-reviews] review denied: [Bug 30526] Supporting multiple OS X versions in one binary : [Attachment 41439] Patch to allow compilation using 10.5 SDK on SnowLeopard

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has denied Kevin Ollivier
<kevino at theolliviers.com>'s request for review:
Bug 30526: Supporting multiple OS X versions in one binary
https://bugs.webkit.org/show_bug.cgi?id=30526

Attachment 41439: Patch to allow compilation using 10.5 SDK on SnowLeopard
https://bugs.webkit.org/attachment.cgi?id=41439&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
It may appear to work but it will have subtle bugs as *all* of the code wrapped
with these macros was written with the assumption that the code within these
blocks was targeted for the specific OS version.  When building in the manner
you mention it will be running on a different version of the OS and may not
behave as expected.  A number of aspects of the code would likely need to be
updated to determine the underlying OS version at runtime and to react
accordingly.

It also doesn’t make sense to switch a single use of BUILDING_ON_TIGER and
BUILDING_ON_LEOPARD to using availability macros.  If we’re going to make this
change it needs to be done in a more consistent manner.