[webkit-reviews] review granted: [Bug 30343] [v8] typeof(HTMLMediaElement) should return undefined if media engine is not available : [Attachment 41254] Patch + manual test case

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Hin-Chung Lam
<hclam at google.com>'s request for review:
Bug 30343: [v8] typeof(HTMLMediaElement) should return undefined if media
engine is not available
https://bugs.webkit.org/show_bug.cgi?id=30343

Attachment 41254: Patch + manual test case
https://bugs.webkit.org/attachment.cgi?id=41254&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
> +	   attribute [Conditional=VIDEO,EnabledAtRuntime]
HTMLAudioElementConstructor HTMLAudioElement;
> +	   attribute [Conditional=VIDEO,EnabledAtRuntime]
HTMLMediaElementConstructor HTMLMediaElement;
> +	   attribute [Conditional=VIDEO,EnabledAtRuntime]
HTMLVideoElementConstructor HTMLVideoElement;
> +	   attribute [Conditional=VIDEO,EnabledAtRuntime] MediaErrorConstructor
MediaError;

Space between IDL attributes would be nice for readability. You can fix upon
landing.