[webkit-reviews] review denied: [Bug 29896] Runtime configurable WebSocket code is detectable when turned off : [Attachment 41395] WebCore: Set EnabledAtRuntime for WebSocket in DOMWindow

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 29896: Runtime configurable WebSocket code is detectable when turned off
https://bugs.webkit.org/show_bug.cgi?id=29896

Attachment 41395: WebCore: Set EnabledAtRuntime for WebSocket in DOMWindow
https://bugs.webkit.org/attachment.cgi?id=41395&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Where is WebSocket::isAvailable() implemented? (And why isn't inside of some v8
guard? I don't think there needs to be an implementation for jsc.)

> diff --git a/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp
b/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp
>  #include "Settings.h"
>  #include "SharedWorkerRepository.h"
>  #include "WindowFeatures.h"
> +#include "WebSocket.h"

Out of alphabetical order.