[webkit-reviews] review denied: [Bug 30508] [libxml2] parsing broken with libxml2 >= 2.7.6 : [Attachment 41416] fix xml parsing with recent versions of libxml2

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 30508: [libxml2] parsing broken with libxml2 >= 2.7.6
https://bugs.webkit.org/show_bug.cgi?id=30508

Attachment 41416: fix xml parsing with recent versions of libxml2
https://bugs.webkit.org/attachment.cgi?id=41416&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> +	    String toParse = "<?xml version=\"1.0\" ?>" + parseString;

doWrite is called several times, once per chunk of data arriving from network.
We certainly can't insert the XML declaration into the middle of XML source.

If no test broke because of this change, we should add one that will (possibly
an http one, to make sending data in chunks easier).

Also, there are tabs in the patch, which should be spaces.