[webkit-reviews] review requested: [Bug 25411] [GTK] ATK accessible ancestry broken : [Attachment 41413] More conservative approach

[bugzilla-daemon at webkit.org]

Joanmarie Diggs <joanmarie.diggs at gmail.com> has asked  for review:
Bug 25411: [GTK] ATK accessible ancestry broken
https://bugs.webkit.org/show_bug.cgi?id=25411

Attachment 41413: More conservative approach
https://bugs.webkit.org/attachment.cgi?id=41413&action=review

------- Additional Comments from Joanmarie Diggs <joanmarie.diggs at gmail.com>
This is a more conservative version of the previous patch:

* Still sets the parent when we ref the child

* Still tries to have the Atk child identify its parent

BUT

* Keeps WebKit's existing implementation of get_parent in place, falling back
to it when the child cannot identify its parent

Doing so seems to solve the bulk of the issues because more often than not, the
user is reading a page and we're descending the accessible hierarchy as a
result. The case it doesn't solve (in theory) is this:

* Some object the user has not interacted with suddenly starts emitting events
on its own, AND

* We have a need for the ancestry to perfectly match the hierarchy

In which case, having fallen back on the old logic, we are no more broken than
we were before. ;-) Rather than try to find such a case in the wild now, I'd
rather focus on the immediate (GNOME 2.30/3.0) needs (i.e. all of the other
a11y bugs we have open). As soon as we find that special case, we can open a
new bug for it.

Thoughts?