[webkit-reviews] review requested: [Bug 30489] [Gtk] The document frame/html container claims to be parentless : [Attachment 41411] revision 2 - made changes Xan suggested

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 19 04:42:54 PDT 2009


Joanmarie Diggs <joanmarie.diggs at gmail.com> has asked  for review:
Bug 30489: [Gtk] The document frame/html container claims to be parentless
https://bugs.webkit.org/show_bug.cgi?id=30489

Attachment 41411: revision 2 - made changes Xan suggested
https://bugs.webkit.org/attachment.cgi?id=41411&action=review

------- Additional Comments from Joanmarie Diggs <joanmarie.diggs at gmail.com>
xan: OK, two really minor things: I think it's worth adding a comment here
explaining why are we doing this, and the last NULL check I think you can get
rid of, since you'd return NULL anyway
xan: I mean the one checking what gtk_widget_get_accessible returns, just
return gtk_widget_get_accessible

----

Done.


More information about the webkit-reviews mailing list