[webkit-reviews] review denied: [Bug 30211] [Qt] Consider prefering QImage* over QPixmap* as NativeImagePtr : [Attachment 40870] Proposed change to change NativeImagePtr to QImage and method to cache certain images as QPixmap

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 18 22:56:03 PDT 2009


Adam Barth <abarth at webkit.org> has denied Holger Freyther <zecke at selfish.org>'s
request for review:
Bug 30211: [Qt] Consider prefering QImage* over QPixmap* as NativeImagePtr
https://bugs.webkit.org/show_bug.cgi?id=30211

Attachment 40870: Proposed change to change NativeImagePtr to QImage and method
to cache certain images as QPixmap
https://bugs.webkit.org/attachment.cgi?id=40870&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I'm not an expert on this code, but in general terms, this patch seems fine. 
However, the patch itself either has tabs or incorrect indenting.


More information about the webkit-reviews mailing list