[webkit-reviews] review denied: [Bug 29178] Geolocation should be refactored to use a single map to store all notifiers : [Attachment 40742] Patch 3 for Bug 29178

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Steve Block <steveblock at google.com>'s
request for review:
Bug 29178: Geolocation should be refactored to use a single map to store all
notifiers
https://bugs.webkit.org/show_bug.cgi?id=29178

Attachment 40742: Patch 3 for Bug 29178
https://bugs.webkit.org/attachment.cgi?id=40742&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This doesn't seem like a win to me.  The code isn't really getting any simpler,
which you can approximate by noting that this patch adds roughly as many lines
as it removes, but the code is getting more obscure.

I haven't studied your use case in detail, but maybe what you really want is a
superclass with two subclasses, one for each type of object you wish to store.

At a higher level, I'm not sure this patch is solving a real problem.