[webkit-reviews] review granted: [Bug 30485] Web Inspector: Properties on Arrays and NodeLists are not logged correctly : [Attachment 41389] patch with no changes to InjectedScript (and a test!)

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 30485: Web Inspector: Properties on Arrays and NodeLists are not logged
correctly
https://bugs.webkit.org/show_bug.cgi?id=30485

Attachment 41389: patch with no changes to InjectedScript (and a test!)
https://bugs.webkit.org/attachment.cgi?id=41389&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> +console-format.html:15["test", "test2", undefined, undefined, "test4"]

It would be nice to have a space or ": " seperator here. Like the CONSOLE
MESSAGE version.


> -function dumpMessages()
> +window.dumpMessages = function(testController)

These are equivlant. If it is a global function, I prefer the old version.


> +	   for (var i = 0; i &lt; messages.length; ++i)

Why &lt; here? I think < would work fine.


> +	       result.push(messages[i].toMessageElement().textContent);

Does this need .replace(/\u200b/g, "")?