[webkit-reviews] review requested: [Bug 30482] [GTK] Expose Page::tabKeyCyclesThroughElements in the API : [Attachment 41381] Page for this issue (WebKitWebSettings version)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 18 10:20:56 PDT 2009


Martin Robinson <martin.james.robinson at gmail.com> has asked  for review:
Bug 30482: [GTK] Expose Page::tabKeyCyclesThroughElements in the API
https://bugs.webkit.org/show_bug.cgi?id=30482

Attachment 41381: Page for this issue (WebKitWebSettings version)
https://bugs.webkit.org/attachment.cgi?id=41381&action=review

------- Additional Comments from Martin Robinson
<martin.james.robinson at gmail.com>
I've attached another patch with this setting in WebKitWebSettings. I initially
wavered as to where to put this, but chose WebKitWebView. My reasoning was that
this would be the first property of WebKitWebSettings that did not have a
direct mapping to WebCore::Settings. I'll leave both patches here so they can
duke it out.

Also, in my previous patch, I wasn't aiming to fix the formatting. The length
of the new method name was longer than the others, so to keep everything lined
up I had to move the rest over.


More information about the webkit-reviews mailing list