[webkit-reviews] review requested: [Bug 25411] [GTK] ATK accessible ancestry broken : [Attachment 41372] proposed patch - take 1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 17 23:29:08 PDT 2009


Joanmarie Diggs <joanmarie.diggs at gmail.com> has asked  for review:
Bug 25411: [GTK] ATK accessible ancestry broken
https://bugs.webkit.org/show_bug.cgi?id=25411

Attachment 41372: proposed patch - take 1
https://bugs.webkit.org/attachment.cgi?id=41372&action=review

------- Additional Comments from Joanmarie Diggs <joanmarie.diggs at gmail.com>
If you set the parent in webkit_accessible_ref_child, the AtkObject will know
who its parent is. This seems (to me) to eliminate the need for WebKit's
implementation of atk_object_get_parent. More importantly, once
webkit_accessible_get_parent is removed, AND the parent has been set, I
suddenly start seeing the correct, expected ancestry.

So.... Is there any reason WebKit should continue to implement
atk_object_get_parent? If there is, it will need smarts to distinguish real
parents from fake ones which seems (to me) to be more hassle than it is worth.
But if there is, let me know and I will give it a go.


More information about the webkit-reviews mailing list