[webkit-reviews] review granted: [Bug 30428] Web Inspector: Handle the Enter Key in the Elements Tree Hierarchy : [Attachment 41270] [PATCH] Enter Key in Tree Hierarchy (improved)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 16 17:01:54 PDT 2009
Timothy Hatcher <timothy at hatcher.name> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 30428: Web Inspector: Handle the Enter Key in the Elements Tree Hierarchy
https://bugs.webkit.org/show_bug.cgi?id=30428
Attachment 41270: [PATCH] Enter Key in Tree Hierarchy (improved)
https://bugs.webkit.org/attachment.cgi?id=41270&action=review
------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> + _startEditingGeneral: function()
Maybe this could just be _startEditing, not sure what "General" means.
> + return this._startEditingTextNode(textNode);
> +
> + return;
Remove the empty line here.
More information about the webkit-reviews
mailing list