[webkit-reviews] review requested: [Bug 30442] Add helper methods to determine whether a transformation matrix is only scaled or translated : [Attachment 41327] Add a mapsRectToRect() helper method to TransformationMatrix.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 16 14:28:22 PDT 2009


Jakob Petsovits <jpetsovits at rim.com> has asked	for review:
Bug 30442: Add helper methods to determine whether a transformation matrix is
only scaled or translated
https://bugs.webkit.org/show_bug.cgi?id=30442

Attachment 41327: Add a mapsRectToRect() helper method to TransformationMatrix.
https://bugs.webkit.org/attachment.cgi?id=41327&action=review

------- Additional Comments from Jakob Petsovits <jpetsovits at rim.com>
Incorporate feedback from smfr and manyoso, stripping down the patch to the
bare minimum and tailoring it for the actual use case it is intended to cover
(checking if a rect is still a rect after the transformation). The isScale()
and isTranslation() methods that I included as "bonus extra" were removed, and
the isScaleOrTranslation() method has been renamed to mapsRectToRect(),
throwing out the 3D parts that are not used for mapRect() calculations.

Please review, thanks!


More information about the webkit-reviews mailing list