[webkit-reviews] review granted: [Bug 30435] Update media layout tests to be codec aware and a V8 binding fix. : [Attachment 41301] Round 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 16 13:36:34 PDT 2009


Eric Carlson <eric.carlson at apple.com> has granted Andrew Scherkus
<scherkus at chromium.org>'s request for review:
Bug 30435: Update media layout tests to be codec aware and a V8 binding fix.
https://bugs.webkit.org/show_bug.cgi?id=30435

Attachment 41301: Round 2
https://bugs.webkit.org/attachment.cgi?id=41301&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
> diff --git a/LayoutTests/media/content/scaled-matrix.ogv
b/LayoutTests/media/content/scaled-matrix.ogv
> new file mode 100644
> index 0000000..1684a7b
> Binary files /dev/null and b/LayoutTests/media/content/scaled-matrix.ogv
differ

Converting this movie to ogg format doesn't sense unless ogg files can contain
a scaling matrix. If they can't it would make more sense to change
video-no-audio.html to use a different video-only movie.

r=me with this change if necessary


More information about the webkit-reviews mailing list