[webkit-reviews] review denied: [Bug 30412] Web Inspector should get human readable DOM Exceptions : [Attachment 41311] Addresses Darin's Comments + Layout Tests

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Brian Weinstein <bweinstein at apple.com>'s
request for review:
Bug 30412: Web Inspector should get human readable DOM Exceptions
https://bugs.webkit.org/show_bug.cgi?id=30412

Attachment 41311: Addresses Darin's Comments + Layout Tests
https://bugs.webkit.org/attachment.cgi?id=41311&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
>  
> +ExceptionBase* toExceptionBase(JSC::JSValue value)
> +{
> +    if (DOMCoreException* domException = toDOMCoreException(value))
> +	   return reinterpret_cast<ExceptionBase*>(domException);
> +    else if (RangeException* rangeException = toRangeException(value))
> +	   return reinterpret_cast<ExceptionBase*>(rangeException);
> +    else if (EventException* eventException = toEventException(value))
> +	   return reinterpret_cast<ExceptionBase*>(eventException);
> +    else if (XMLHttpRequestException* xmlHttpException =
toXMLHttpRequestException(value))
> +	   return reinterpret_cast<ExceptionBase*>(xmlHttpException);
> +#if ENABLE(SVG)
> +    else if (SVGException* svgException = toSVGException(value))
> +	   return reinterpret_cast<ExceptionBase*>(svgException);
> +#endif
> +#if ENABLE(XPATH)
> +    else if (XPathException* pathException = toXPathException(value))
> +	   return reinterpret_cast<ExceptionBase*>(pathException);
> +#endif
> +    
> +    return 0;
> +}

This is in the wrong place.  For the most part, the DOM should not know about
the bindings.  This should instead be in a new file in WebCore/bindings/js/
called something like JSExceptionBase.h/cpp.