[webkit-reviews] review granted: [Bug 30362] check-webkit-style is wrong about indent checking in namespaces in header files : [Attachment 41291] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 16 11:15:11 PDT 2009


David Levin <levin at chromium.org> has granted Carol Szabo
<carol.szabo at nokia.com>'s request for review:
Bug 30362: check-webkit-style is wrong about indent checking in namespaces in
header files
https://bugs.webkit.org/show_bug.cgi?id=30362

Attachment 41291: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=41291&action=review

------- Additional Comments from David Levin <levin at chromium.org>

> Index: WebKitTools/Scripts/modules/cpp_style.py
> +    if current_indentation_level > 0:
> +	   error(filename, line_number, 'whitespace/indent', 4,
> +			     'namespace should never be indented.')

The indentation is off here.

I'll fix this on landing.


More information about the webkit-reviews mailing list