[webkit-reviews] review requested: [Bug 30362] check-webkit-style is wrong about indent checking in namespaces in header files : [Attachment 41291] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 16 09:43:33 PDT 2009


Carol Szabo <carol.szabo at nokia.com> has asked  for review:
Bug 30362: check-webkit-style is wrong about indent checking in namespaces in
header files
https://bugs.webkit.org/show_bug.cgi?id=30362

Attachment 41291: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=41291&action=review

------- Additional Comments from Carol Szabo <carol.szabo at nokia.com>
This addresses Levin's comments.
I have run the check-webkit-style scripth before and after my changes through
the entire WebKit source and I have spot checked issues. At the moment other
than the scenario described earlier in the comments, which I understand not to
be a favored code style anyway, I saw no false warnings.


More information about the webkit-reviews mailing list