[webkit-reviews] review requested: [Bug 30440] [GTK] Fails new test fast/js/navigator-language.html : [Attachment 41288] reimplementation of defaultLanguage

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has asked  for review:
Bug 30440: [GTK] Fails new test fast/js/navigator-language.html
https://bugs.webkit.org/show_bug.cgi?id=30440

Attachment 41288: reimplementation of defaultLanguage
https://bugs.webkit.org/attachment.cgi?id=41288&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
This test is failing because GTK+/Pango don't support changing locale after the
first gtk_init() call, thus our defaultLanguage() implementation always returns
whatever you had when you first started. I am not really sure about the patch.
WebKit's notion of locale will diverge from GTK+'s in case the application
changes setlocale(). If the application doing that expects WebKit to behave
like GTK+ (ignore setlocale changes), this may be bad. The other way of making
this test pass is to run an instance of DRT for it exclusively, which sounds
like complex and FAIL to me.