[webkit-reviews] review granted: [Bug 27490] Web Sockets Test Infrastructure Part 1/3: Server : [Attachment 41268] add mod_pywebsocket to test Web Sockets

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Yuzo Fujishima <yuzo at google.com>'s
request for review:
Bug 27490: Web Sockets Test Infrastructure Part 1/3: Server
https://bugs.webkit.org/show_bug.cgi?id=27490

Attachment 41268: add mod_pywebsocket to test Web Sockets
https://bugs.webkit.org/attachment.cgi?id=41268&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Thanks for addressing my comments even though you are basically importing a 3rd
party project into WebKit.

I think there are only a few things relevant to this review:
1. Is the license compatible with WebKit?
Yes, it is BSD.

2. Does this module implement something useful to WebKit?
After reviewing it, it appears to correctly implement the server side of Web
Sockets which is useful for testing. (And there have been other reviews in the
external project.)

3. Is it possible to integrate this into the layout test run without having
every developer/machine install something?
Yes. It will use standalone.py for this.

Given the affirmative answers on these items. It seems like this should go in.