[webkit-reviews] review requested: [Bug 30407] HTML 5 media elements should set network state to NETWORK_EMPTY if they do not have a source : [Attachment 41255] Round 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 15 17:59:33 PDT 2009


Andrew Scherkus <scherkus at chromium.org> has asked  for review:
Bug 30407: HTML 5 media elements should set network state to NETWORK_EMPTY if
they do not have a source
https://bugs.webkit.org/show_bug.cgi?id=30407

Attachment 41255: Round 2
https://bugs.webkit.org/attachment.cgi?id=41255&action=review

------- Additional Comments from Andrew Scherkus <scherkus at chromium.org>
Few things (as mentioned in the patch):
  - Having no source is defined as a null src attribute and no <source>
children, and should result in the element going to NETWORK_EMPTY
  - Empty string "" is considered a valid src attribute and should be loaded
(before it slipped through the cracks and the element would get jammed in
NETWORK_LOADING)


More information about the webkit-reviews mailing list