[webkit-reviews] review granted: [Bug 28986] Add support for noreferrer link relation : [Attachment 41062] Attempt #3

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 28986: Add support for noreferrer link relation
https://bugs.webkit.org/show_bug.cgi?id=28986

Attachment 41062: Attempt #3
https://bugs.webkit.org/attachment.cgi?id=41062&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> +// const unsigned long RELATION_ALTERNATE   = 0x00000001;

We only use uppercase names for #defined constants - these should use normal
interCaps style. But I'd actually suggest using an enum for these (enum members
should user InterCaps with an initial capital letter).

> +    void setRel(const AtomicString&);

Why is this an atomic string? Rel values are arbitrary combinations of tokens,
and you just parse it immediately anyway. Please use plain String.

> +    unsigned long m_linkRelations;

No need to take 8 bytes on 64 bit systems; I suggest using uint32_t.

r=me on a condition that you address these comments.