[webkit-reviews] review granted: [Bug 29653] [Qt] Qt-based browser fails to show the right language translation : [Attachment 41241] new patch with test case checks "en"

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 15 13:21:11 PDT 2009


Eric Seidel <eric at webkit.org> has granted Chang Shu <Chang.Shu at nokia.com>'s
request for review:
Bug 29653: [Qt] Qt-based browser fails to show the right language translation
https://bugs.webkit.org/show_bug.cgi?id=29653

Attachment 41241: new patch with test case checks "en"
https://bugs.webkit.org/attachment.cgi?id=41241&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks fine.  The spec comment didn't actually have to go in the description, it
could just have been a javascript comment.  Thanks.

Also, the spec comment is about case insensitivity and yet we don't actually
deal with case insensitivity in the test.  Or at least not directly.  But
again, it's fine.


More information about the webkit-reviews mailing list