[webkit-reviews] review granted: [Bug 30372] Make typeinfo flags default to false : [Attachment 41237] HasDefaultMark to OverridesMarkChildren

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 30372: Make typeinfo flags default to false
https://bugs.webkit.org/show_bug.cgi?id=30372

Attachment 41237: HasDefaultMark to OverridesMarkChildren
https://bugs.webkit.org/attachment.cgi?id=41237&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -	   return Structure::create(prototype, TypeInfo(ObjectType));
> +	   return Structure::create(prototype, TypeInfo(ObjectType, 
JSC::OverridesGetOwnPropertySlot | JSC::HasNonDefaultMark));

Extra space here, and "JSC::" is not needed.

I guess the assertion we have will catch if we got this wrong anywhere at
runtime. Please be sure to run all the regression tests before landing since
that will be caught at runtime, not compile time.

r=me