[webkit-reviews] review granted: [Bug 29946] [Qt] Port YARR JIT for Symbian (implement ExecutableAllocator) : [Attachment 41213] ExecutableAllocator III.

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 29946: [Qt] Port YARR JIT for Symbian (implement ExecutableAllocator)
https://bugs.webkit.org/show_bug.cgi?id=29946

Attachment 41213: ExecutableAllocator III.
https://bugs.webkit.org/attachment.cgi?id=41213&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>

> +#if ARM_ARCH_VERSION <= 5

This is really a nit-pick comment from here, but in the unlikely event of us
ever introducing
the JIT for the emulator (hehehe) I guess then this should've been using
PLATFORM_ARM_ARCH(5) in reverse logic, that also
verifies the presence of PLATFORM(ARM). Just a thought though, feel free to
leave it as it is right now, as certainly
with the current code ENABLE(ASSEMBLER) will only be used when compiling for
arm.

Otherwise the patch looks good to me!