[webkit-reviews] review granted: [Bug 30002] [GStreamer] MediaPlayerPrivate::cancelLoad() can be implemented by setting state to NULL : [Attachment 41160] proposed patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 30002: [GStreamer] MediaPlayerPrivate::cancelLoad() can be implemented by
setting state to NULL
https://bugs.webkit.org/show_bug.cgi?id=30002

Attachment 41160: proposed patch
https://bugs.webkit.org/attachment.cgi?id=41160&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
>  void MediaPlayerPrivate::cancelLoad()
>  {
> -    notImplemented();
> +    if (m_networkState < MediaPlayer::Loading || m_networkState ==
MediaPlayer::Loaded)
> +	   return;
> +
> +    if (m_playBin)
> +	   gst_element_set_state(m_playBin, GST_STATE_NULL);
>  }

According to further investigation by Philippe, updateStates is always called
on element state transitions, so it is being done here.