[webkit-reviews] review denied: [Bug 30353] [GStreamer] Race condition causing deadlocks : [Attachment 41156] 0001-Fix-race-condition-in-unlock-render-that-would-lead-.patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Sebastian Dröge
<slomo at circular-chaos.org>'s request for review:
Bug 30353: [GStreamer] Race condition causing deadlocks
https://bugs.webkit.org/show_bug.cgi?id=30353

Attachment 41156:
0001-Fix-race-condition-in-unlock-render-that-would-lead-.patch
https://bugs.webkit.org/attachment.cgi?id=41156&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
Man, threading is hairy =). So, what's causing the deadlock, exactly, again?
The cond_wait in render and the mutex_lock in timeout_func racing when
gstreamer fires ::unlock? Then you fix it by avoiding creating the timeout and
doing the cond_wait in the first place if ::unlock() has fired on the element,
is that it? Can you add a comment block somewhere explaining this?