[webkit-reviews] review denied: [Bug 29910] Load state can get out of sync in a client callback, leading to a crash. : [Attachment 40733] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Yael <yael.aharon at nokia.com>'s
request for review:
Bug 29910: Load state can get out of sync in a client callback, leading to a
crash.
https://bugs.webkit.org/show_bug.cgi?id=29910

Attachment 40733: Patch
https://bugs.webkit.org/attachment.cgi?id=40733&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
r- for lack of a test.	That progress callback generates a bunch of
FrameLoaderClient callbacks.  I'm sure those generate some number of WebKit
client callbacks that DumpRenderTree could listen to and respond with a load,
triggering the crash.

Don't be shy about extending DumpRenderTree to call the WebKit API in crazy
ways.  Ideally we'd have some generalized mechanism for this, but we can start
with a one-off test harness if you don't see a way to generalize it.