[webkit-reviews] review requested: [Bug 29909] [V8] Chromium's implementation of ScriptString is awful for XHR's responseText : [Attachment 41196] Uses OwnHandle<v8::String> instead of a v8::Persistent<v8::String> for management

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 14 18:26:49 PDT 2009


James Robinson <jamesr at chromium.org> has asked	for review:
Bug 29909: [V8] Chromium's implementation of ScriptString is awful for XHR's
responseText
https://bugs.webkit.org/show_bug.cgi?id=29909

Attachment 41196: Uses OwnHandle<v8::String> instead of a
v8::Persistent<v8::String> for management
https://bugs.webkit.org/attachment.cgi?id=41196&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
I'm going to double-check with V8 experts about the persistent handle use, but
this version passes tests and loads up gmail so I believe it's correct.


More information about the webkit-reviews mailing list