[webkit-reviews] review denied: [Bug 29909] [V8] Chromium's implementation of ScriptString is awful for XHR's responseText : [Attachment 41195] Implementation using v8::String::Concat() for operator+=

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 14 17:33:35 PDT 2009


Adam Barth <abarth at webkit.org> has denied James Robinson
<jamesr at chromium.org>'s request for review:
Bug 29909: [V8] Chromium's implementation of ScriptString is awful for XHR's
responseText
https://bugs.webkit.org/show_bug.cgi?id=29909

Attachment 41195: Implementation using v8::String::Concat() for operator+=
https://bugs.webkit.org/attachment.cgi?id=41195&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
That looks great!  One nit: please use OwnHandle to avoid manually allocating
and deallocating the handle.

http://trac.webkit.org/browser/trunk/WebCore/bindings/v8/OwnHandle.h


More information about the webkit-reviews mailing list