[webkit-reviews] review requested: [Bug 30362] check-webkit-style is wrong about indent checking in namespaces in header files : [Attachment 41179] Proposed Patch

[bugzilla-daemon at webkit.org]

Carol Szabo <carol.szabo at nokia.com> has asked  for review:
Bug 30362: check-webkit-style is wrong about indent checking in namespaces in
header files
https://bugs.webkit.org/show_bug.cgi?id=30362

Attachment 41179: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=41179&action=review

------- Additional Comments from Carol Szabo <carol.szabo at nokia.com>
This patch addresses some of the issues seen with check-webkit-style
It has limited handling of preprocessor directives, thus it may generate a few
false errors when a #if directive with #else clause is used at the end of a
statement such as here:
namespace test {
void f(
#if HAVE(LONG_LONG_INT)
    long long int);
#else
    long int);
#endif
}

It will complain about the spacing before the 6th line since it will think that
the function declaration has finished on the 4th line.

But it addresses many false errors about indentation in header files containing
the namespace reserved word. Also it improves handling of spacing around binary
operators.