[webkit-reviews] review denied: [Bug 19490] caret is not displayed in proper location when non-wrappable-word exceeds the boundary of its container. : [Attachment 41119] Update proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 14 09:14:57 PDT 2009


Dave Hyatt <hyatt at apple.com> has denied Victor Wang <victorw at chromium.org>'s
request for review:
Bug 19490: caret is not displayed in proper location when non-wrappable-word
exceeds the boundary of its container.
https://bugs.webkit.org/show_bug.cgi?id=19490

Attachment 41119: Update proposed patch
https://bugs.webkit.org/attachment.cgi?id=41119&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
The line in this test:

window.getSelection().setPosition(body, body.offsetLeft + body.offsetWidth);

makes no sense.  setPosition takes a range offset and not a pixel offset.


More information about the webkit-reviews mailing list