[webkit-reviews] review granted: [Bug 29302] NPAPI plugin support feature on Webkit for S60 platform : [Attachment 41161] Updated patch after hash changes landed
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 14 08:43:54 PDT 2009
Simon Hausmann <hausmann at webkit.org> has granted Yael <yael.aharon at nokia.com>'s
request for review:
Bug 29302: NPAPI plugin support feature on Webkit for S60 platform
https://bugs.webkit.org/show_bug.cgi?id=29302
Attachment 41161: Updated patch after hash changes landed
https://bugs.webkit.org/attachment.cgi?id=41161&action=review
------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
> +class NPInterface {
> +public:
> + virtual NPError NP_Initialize(NPNetscapeFuncs *aNPNFuncs, NPPluginFuncs
*aNPPFuncs) = 0;
Please fix the coding style (* placement) when landing.
> +{
> + if (platformPluginWidget())
> + delete platformPluginWidget();
This null pointer check is not needed.
More information about the webkit-reviews
mailing list