[webkit-reviews] review denied: [Bug 30328] Web Inspector: Migrate profiles to the injected script-based schema. : [Attachment 41153] proposed change, comments addressed

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 30328: Web Inspector: Migrate profiles to the injected script-based schema.
https://bugs.webkit.org/show_bug.cgi?id=30328

Attachment 41153: proposed change, comments addressed
https://bugs.webkit.org/attachment.cgi?id=41153&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
> +    void getProfileHeaders(long callId);
> +    void getProfile(long callId, unsigned uid);

These should be private in InspectorController.

> +	   function profileCallback(profile) {
> +	       self.profile = profile;
> +	       continueInitialization();
> +	   }

{ on next line

> +	   if (!this.profile._isStub)

Why do you end up with profiles in different states? I think you should resolve
profile only here and only once.

Otherwise r+.