[webkit-reviews] review denied: [Bug 30319] Lines on Chrome's horizontal scrollbars should be vertical : [Attachment 41142] fix drawing of lines

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 13 17:52:27 PDT 2009


David Levin <levin at chromium.org> has denied Evan Martin <evan at chromium.org>'s
request for review:
Bug 30319: Lines on Chrome's horizontal scrollbars should be vertical
https://bugs.webkit.org/show_bug.cgi?id=30319

Attachment 41142: fix drawing of lines
https://bugs.webkit.org/attachment.cgi?id=41142&action=review

------- Additional Comments from David Levin <levin at chromium.org>
r- on this patch for 3 reasons:
1. It does more than it says. It changes how the horizontal lines are drawn
without explanation (nothing in the changelog and the bug only mentions the
other direction).
2. It uses a lot of "magic" numbersy. It would be nice to make constants out of
some of them to help inform the reader what they are.
3. It is unclear if there are any layout tests which cover this change.


More information about the webkit-reviews mailing list