[webkit-reviews] review requested: [Bug 30347] Uninitialized conditional in WebCore::CSSParser::validUnit with "width: %" style : [Attachment 41139] Move the non-negative check after the switch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 13 17:06:09 PDT 2009


Matt Mueller <mattm at chromium.org> has asked  for review:
Bug 30347: Uninitialized conditional in WebCore::CSSParser::validUnit with
"width: %" style
https://bugs.webkit.org/show_bug.cgi?id=30347

Attachment 41139: Move the non-negative check after the switch
https://bugs.webkit.org/attachment.cgi?id=41139&action=review

------- Additional Comments from Matt Mueller <mattm at chromium.org>
Yeah, that does look more general.  Should fix 22772 too, though I don't have a
test case for that.  I've updated the patch.


More information about the webkit-reviews mailing list