[webkit-reviews] review denied: [Bug 26083] How to access formatted Java script Console message ? : [Attachment 40070] Fix for formatted js console log message. Added some info to ChangeLog as suggested by Eric.S

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Gopal Raghavan <gop.rag at gmail.com>'s
request for review:
Bug 26083: How to access formatted Java script Console message ?
https://bugs.webkit.org/show_bug.cgi?id=26083

Attachment 40070: Fix for formatted js console log message. Added some info to
ChangeLog as suggested by Eric.S
https://bugs.webkit.org/attachment.cgi?id=40070&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
+ getMessageSourceAndLevelPrefix(source,level,sourceString,levelString);

We need spaces after the commas here.

+ getAllArgumentsAsString(callStack,message);

Here too.

+ void Console::getAllArgumentsAsString(ScriptCallStack* callStack, String&
message)

Please remove leading blank line from this function.

+ if (i==0 && lastCaller.argumentAt(i).jsValue().isString()) {

We need spaces around the ==

There are too many style violations for me to review them all, much less
understand the content of the patch.  Have you run check-webkit-style on your
patch?