[webkit-reviews] review denied: [Bug 26994] Store non-standard HTTP headers in history : [Attachment 40068] Patch #4 to resolve bug 26994

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 13 14:55:26 PDT 2009


Adam Barth <abarth at webkit.org> has denied Marshall Greenblatt
<magreenblatt at gmail.com>'s request for review:
Bug 26994: Store non-standard HTTP headers in history
https://bugs.webkit.org/show_bug.cgi?id=26994

Attachment 40068: Patch #4 to resolve bug 26994
https://bugs.webkit.org/attachment.cgi?id=40068&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Darin asked for a regression test, but you did not provide one.  Also, this
patch is missing a ChangeLog.

In general, this header list seems to overlap significantly with the
XMLHttpRequest black list.  Are the lists actually the same?  Is one a subset
of the other?  I'd like to see an explanation of any differences.


More information about the webkit-reviews mailing list