[webkit-reviews] review denied: [Bug 29118] StringHash support searching for empty/null strings rather than requiring callers to explicitly check : [Attachment 39324] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 13 13:27:53 PDT 2009


Adam Barth <abarth at webkit.org> has denied TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 29118: StringHash support searching for empty/null strings rather than
requiring callers to explicitly check
https://bugs.webkit.org/show_bug.cgi?id=29118

Attachment 39324: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=39324&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I like the part of this change that removes a bunch of copy-paste code having
to do with avalanches.	It seems like we can unblock this bug with:

1) Benchmarks that show this change doesn't slow us down too much.
2) Examples of crashes that this change fixes.

Until we get this data, this patch isn't really suitable for reviewing.  Feel
free to re-nominate when you provide the data.


More information about the webkit-reviews mailing list